Correct buffer size to fix memory corruption #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The analysis in eclipse-openj9/openj9#5696 shows that there is a out of bounds access that is fixed by increasing the buffer size by 8. Validated by having the VM increase all unsafe allocates by 8 and the problem no longer occurs. fixes: kohsuke#79 Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
Structure contains pointers so its size depends on whether the system is 32 or 64 bit Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kohsuke#80